Conversation
TanmayArya-1p
force-pushed
the
snapshot
branch
from
30521a0 to
756766a
Compare
| } | ||
|
|
||
| #[test] | ||
| fn test_create_and_load_snapshot() { |
There was a problem hiding this comment.
these tests give an overview of how the snapshots api is to be used
4adex
left a comment
4adex
left a comment
There was a problem hiding this comment.
Fix error handling in these certain places
crates/snapshot/src/engine/mod.rs
Outdated
| .lock() | ||
| .unwrap() | ||
| .add_snapshot(&snapshot_path) | ||
| .unwrap(); |
There was a problem hiding this comment.
Propagate error or panic if needed but don't use excessive unwraps. Also check other unwraps in engine. (unwraps are okay in tests only)
There was a problem hiding this comment.
removed the unwraps in the engine except for the ones in the worker thread. not sure how to handle errors in the worker thread(do i panic?). I'll look into best practices for this
There was a problem hiding this comment.
refactored error handling in worker thread in 76e3afb
crates/snapshot/src/lib.rs
Outdated
| "Storage checkpoint was not properly made".to_string(), | ||
| ))? | ||
| .to_str() | ||
| .unwrap() |
|
@TanmayArya-1p rebase and resolve conflicts |
|
@4adex fixed the merge conflicts. the snapshots crate and most of the snapshots related code does not use snafu for error handling, we need to address this later |
2 participants
Addresses #38